[ovs-dev] [PATCH v3] Rapid Spanning Protocol Implementation (IEEE 802.1D) + functional tests

[Jarno Rajahalme]

On Apr 29, 2014, at 7:40 AM, Martino Fornasa <mf at fornasa.it> wrote:

> Jarno Rajahalme wrote:
>> 
>> Also, we have defined the type ‘stp_identifier’ in lib/stp.h. I’d like you to use it (with the accompanying formatting tools) also for RSTP (maybe move them to lib/util.h to use them both from STP and RSTP).
> I would prefer to define a separate rstp_identifier as uint64_t. This is because STP and RSTP identifier are encoded differently:
> 
> * In STP, there are 16 bits for the priority and 48 bits for the MAC address
> * In RSTP, there are 4 bits for priority, 12 bits for private extension (used in the Multiple Spanning Tree Protocol to identify the tree instance) and 48 bits for the MAC address.
> 
> Thus, the formatting tools are not really compatible (and they will be less compatible if someone try to implement the Multiple Spanning Tree Protocol on top of our code).
> 

OK, thats fine.

  Jarno