[ovs-dev] [PATCH 02/10] lib: Inline functions used in classifier_lookup

[Jarno Rajahalme]

On Apr 24, 2014, at 5:31 PM, Ethan Jackson <ethan at nicira.com> wrote:

> The first line in the commit message needs a period.
> 

Thanks.

> As Yamamoto asked, please verify that this actually helps.  If it
> doesn't I'd prefer not to merge it.
> 

This helps in the range of 1% in TCP_CRR performance test. However, this also helps by clearly showing the classifier_lookup() cost in perf reports as one item.

> I think we need to get rid of the hindex anyways, so I'd prefer we
> don't inline it now.
> 

We can revert the inlining of hindex_node_with_hash() at that time.

Otherwise this patch makes it simpler to delete functions if they become unnecessary for the classifier at some point in time, as (most of) these are only used by the classifier.

> Assuming the above is addressed:
> 
> Acked-by: Ethan Jackson <ethan at nicira.com>
> 

Thanks, will push soon.

  Jarno