[ovs-dev] [PATCH] bond: fix uninitialized use of use_recirc variable

Pritesh Kothari (pritkoth) pritkoth at cisco.com
Tue Apr 29 21:13:31 UTC 2014


works for me here.

Acked-by: Pritesh Kothari <pritesh.kothari at cisco.com>

On Apr 29, 2014, at 1:22 PM, Andy Zhou <azhou at nicira.com> wrote:

> Caught by clang-3.5.
> 
> Reported-by: Simon Horman <horms at verge.net.au>
> Signed-off-by: Andy Zhou <azhou at nicira.com>
> ---
> ofproto/bond.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/ofproto/bond.c b/ofproto/bond.c
> index f5a9d47..c1a8448 100644
> --- a/ofproto/bond.c
> +++ b/ofproto/bond.c
> @@ -1180,10 +1180,11 @@ bond_rebalance(struct bond *bond)
>         e->tx_bytes /= 2;
>     }
> 
> -done:
>     if (use_recirc && rebalanced) {
>         bond_update_post_recirc_rules(bond,true);
>     }
> +
> +done:
>     ovs_rwlock_unlock(&rwlock);
> }
> 
> -- 
> 1.9.1
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev




More information about the dev mailing list