[ovs-dev] [PATCH 07/10] classifier: Use array for subtables instead of a list.

Ethan Jackson ethan at nicira.com
Tue Apr 29 21:32:30 UTC 2014


Sounds good.

Ethan

On Tue, Apr 29, 2014 at 12:58 PM, Jarno Rajahalme <jrajahalme at nicira.com> wrote:
>
> On Apr 24, 2014, at 6:15 PM, Ethan Jackson <ethan at nicira.com> wrote:
>
>> In the cache_push_back function, you might consider using the
>> x2nrealloc() function.
>>
>
> I did not know this existed, thanks!
>
>> Does this actually help?  I've found we spend most of our time getting
>> the memory for the rule, not the subtable itself.
>>
>
> After this series I see cache misses only on fetching the ‘next’ rule. Before, I saw also misses for the subtable (being fetched via a next pointer as well) and/or it’s mask. So this helps :-)
>
>         Jarno
>



More information about the dev mailing list