[ovs-dev] [PATCH v6 00/18] Rapid Spanning Tree Protocol

Jarno Rajahalme jrajahalme at nicira.com
Wed Aug 20 23:57:12 UTC 2014


I took my time starting the review, so I decided address issues as I
see them rather than just comment on them.

The first patch of this series is a minimally rebased version of the
v5 sent on ovs-dev on June 12th, 2014.  Rest of the series is my
proposal for fixes and enhancements.

I could have reordered and squashed some of the patches together, but
that would have been more work...

Daniele Venturino (1):
  Rapid Spanning Tree Protocol (IEEE 802.1D).

Jarno Rajahalme (17):
  lib/stp,rstp: Add unit more unit tests.
  lib/stp: Some debugging support.
  lib/rstp: Better debug messages, style fixes.
  vswitch.xml: Fix RSTP configuration documentation.
  lib/rstp: Remove unused struct rstp_priority_vector4
  lib/rstp: Coding style fixes.
  lib/rstp: Refactor priority vector recalculation.
  lib/rstp: Refactor port number allocation.
  lib/rstp: Refactor port initialization.
  lib/rstp: CodingStyle changes.
  lib/rstp: Inline trivial predicate functions.
  lib/rstp: More robust thread safety.
  lib/rstp: Remove lock recursion.
  lib/rstp: CodingStyle fixes.
  lib/rstp: Simplify priority vector comparison.
  lib/rstp: Eliminate ports_count.
  lib/rstp: Use hmap instead of a list for ports.

 AUTHORS                      |    1 +
 NOTICE                       |    3 +
 lib/automake.mk              |    5 +
 lib/packets.h                |    5 +
 lib/rstp-common.h            |  879 ++++++++++++++++++
 lib/rstp-state-machines.c    | 2025 ++++++++++++++++++++++++++++++++++++++++++
 lib/rstp-state-machines.h    |   46 +
 lib/rstp.c                   | 1369 ++++++++++++++++++++++++++++
 lib/rstp.h                   |  290 ++++++
 lib/stp.c                    |    7 +-
 lib/stp.h                    |    5 -
 ofproto/ofproto-dpif-xlate.c |  157 +++-
 ofproto/ofproto-dpif-xlate.h |    6 +-
 ofproto/ofproto-dpif.c       |  255 +++++-
 ofproto/ofproto-provider.h   |   47 +
 ofproto/ofproto.c            |   84 ++
 ofproto/ofproto.h            |   50 ++
 tests/.gitignore             |    1 +
 tests/automake.mk            |    3 +
 tests/ovs-vsctl.at           |    4 +
 tests/rstp.at                |  235 +++++
 tests/stp.at                 |  100 +++
 tests/test-rstp.c            |  714 +++++++++++++++
 tests/testsuite.at           |    1 +
 utilities/ovs-vsctl.8.in     |   79 ++
 vswitchd/bridge.c            |  295 ++++++
 vswitchd/vswitch.ovsschema   |   15 +-
 vswitchd/vswitch.xml         |  131 ++-
 28 files changed, 6749 insertions(+), 63 deletions(-)
 create mode 100644 lib/rstp-common.h
 create mode 100644 lib/rstp-state-machines.c
 create mode 100644 lib/rstp-state-machines.h
 create mode 100644 lib/rstp.c
 create mode 100644 lib/rstp.h
 create mode 100644 tests/rstp.at
 create mode 100644 tests/test-rstp.c

-- 
1.7.10.4




More information about the dev mailing list