[ovs-dev] [PATCH] datapath-windows - fix crash when internal port is removed

Nithin Raju nithin at vmware.com
Fri Aug 1 00:30:27 UTC 2014

On Jul 31, 2014, at 5:22 PM, Eitan Eliahu <eliahue at vmware.com>

> 3. If clearing the context from will be  removed from OvsCompleteNBLForwardingCtx then we need to call OvsClearTunCtx() on all error paths of this function. Apply it only to this path does not buy anything here.

Currently, it does so. The current code unconditionally calls OvsClearTunTxCtx() on success and failure paths. Since the change you are adds a new return point, we just need to add a call to OvsClearTunTxCtx() in that case as well. Maybe a comment will also be great.

> 4. This state is caused by misconfiguration. This should be blocked in user mode so I don't see a lot of meaning for incrementing a counter.


> A better approach would be just to fail the driver Attach callback but I would defer it for later. This change is just to prevent the BSOD.


-- Nithin

More information about the dev mailing list