[ovs-dev] [PATCH] [PATCH] datapath-windows - fix crash when internal port is removed

Saurabh Shah ssaurabh at vmware.com
Fri Aug 1 16:51:13 UTC 2014

I think since we are allowing AllowManagementOS to be disabled we
shouldn’t crash on debug builds either. Can you please test on a debug
build to make sure it doesn’t crash?

Also, it would help if you version the patches such as "[PATCH v2]", so
that its easy to know which is the latest one.


From:  Eitan Eliahu <eliahue at vmware.com>
Date:  Thursday, July 31, 2014 at 4:46 PM
To:  Saurabh Shah <ssaurabh at vmware.com>, "dev at openvswitch.org"
<dev at openvswitch.org>
Subject:  RE: [ovs-dev] [PATCH] [PATCH] datapath-windows - fix crash when
internal port is removed

>Hi Saurabh, I removed the assert in the next patch I posted. But, in
>anyway, since ASSERT does not generate any code for release build it does
>-----Original Message-----
>From: Saurabh Shah
>Sent: Thursday, July 31, 2014 4:40 PM
>To: Eitan Eliahu; dev at openvswitch.org
>Subject: Re: [ovs-dev] [PATCH] [PATCH] datapath-windows - fix crash when
>internal port is removed
>Hey Eitan,
>>BSOD while setting AllowManagementOS on $false #13
>>Signed-off-by: Eitan Eliahu <eliahue at vmware.com>
>> datapath-windows/ovsext/OvsActions.c | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>diff --git a/datapath-windows/ovsext/OvsActions.c
>>index 79fb50f..62a98fa 100644
>>--- a/datapath-windows/ovsext/OvsActions.c
>>+++ b/datapath-windows/ovsext/OvsActions.c
>>@@ -581,7 +581,12 @@ OvsTunnelPortTx(OvsForwardingContext *ovsFwdCtx)
>>      * Setup the source port to be the internal port to as to
>>facilitate the
>>      * second OvsLookupFlow.
>>      */
>>-    ASSERT(ovsFwdCtx->switchContext->internalVport);
>>+    if (ovsFwdCtx->switchContext->internalVport == NULL) {
>>+        ASSERT(ovsFwdCtx->switchContext->internalVport);
>This can¹t work because you are still asserting in the if() case. Perhaps
>you forgot to remove the assert?
>>+        OvsCompleteNBLForwardingCtx(ovsFwdCtx,
>>+                                    L"OVS-Dropped - internal port
>>+        return NDIS_STATUS_FAILURE;
>>+    }
>>     ovsFwdCtx->srcVportNo =
>>dev mailing list
>>dev at openvswitch.org

More information about the dev mailing list