[ovs-dev] [PATCH] datapath-windows - fix crash when internal port is removed

Ben Pfaff blp at nicira.com
Fri Aug 1 20:29:34 UTC 2014


On Fri, Aug 01, 2014 at 08:19:55PM +0000, Nithin Raju wrote:
> 
> On Aug 1, 2014, at 5:11 PM, Eitan Eliahu <eliahue at vmware.com>
>  wrote:
> 
> > BSOD while setting AllowManagementOS on $false #13
> > Github Issue: #13
> > 
> > Signed-off-by: Eitan Eliahu <eliahue at vmware.com>
> > Reported-by: Alin Serdean <aserdean at cloudbasesolutions.com>
> > ---
> > datapath-windows/ovsext/OvsActions.c | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/datapath-windows/ovsext/OvsActions.c b/datapath-windows/ovsext/OvsActions.c
> > index 79fb50f..4a2c117 100644
> > --- a/datapath-windows/ovsext/OvsActions.c
> > +++ b/datapath-windows/ovsext/OvsActions.c
> > @@ -581,7 +581,12 @@ OvsTunnelPortTx(OvsForwardingContext *ovsFwdCtx)
> >      * Setup the source port to be the internal port to as to facilitate the
> >      * second OvsLookupFlow.
> >      */
> > -    ASSERT(ovsFwdCtx->switchContext->internalVport);
> > +    if (ovsFwdCtx->switchContext->internalVport == NULL) {
> > +        OvsClearTunTxCtx(ovsFwdCtx);
> > +        OvsCompleteNBLForwardingCtx(ovsFwdCtx,
> > +            L"OVS-Dropped since internal port is absent");
> > +        return NDIS_STATUS_FAILURE;
> > +    }
> >     ovsFwdCtx->srcVportNo =
> >         ((POVS_VPORT_ENTRY)ovsFwdCtx->switchContext->internalVport)->portNo;
> 
> Acked-by: Nithin Raju <nithin at vmware.com>

Thanks everyone.

I updated the commit message to the following to make it better fit
the style generally used, and applied this to master.

    datapath-windows: Fix crash when internal port is removed.
    
    Avoids a BSOD when AllowManagementOS is set to false.
    
    Reported-at: https://github.com/openvswitch/ovs/issues/13
    Reported-by: Alin Serdean <aserdean at cloudbasesolutions.com>
    Signed-off-by: Eitan Eliahu <eliahue at vmware.com>
    Signed-off-by: Ben Pfaff <blp at nicira.com>
    Acked-by: Nithin Raju <nithin at vmware.com>



More information about the dev mailing list