[ovs-dev] [DPDK Upcalls 01/11] style: Replace TODO with XXX.

Ethan Jackson ethan at nicira.com
Sat Aug 2 01:39:12 UTC 2014


In accordance with CodingStyle.

Signed-off-by: Ethan Jackson <ethan at nicira.com>
---
 lib/dpif-netdev.c |  4 ++--
 lib/netdev-dpdk.c | 10 +++++-----
 ofproto/bundles.c |  4 ++--
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index bbc4eea..76e36d9 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -1690,7 +1690,7 @@ reload:
         if (lc++ > 1024) {
             ovsrcu_quiesce();
 
-            /* TODO: need completely userspace based signaling method.
+            /* XXX: need completely userspace based signaling method.
              * to keep this thread entirely in userspace.
              * For now using atomic counter. */
             lc = 0;
@@ -2112,7 +2112,7 @@ dp_execute_cb(void *aux_, struct dpif_packet **packets, int cnt,
 
         for (i = 0; i < cnt; i++) {
 
-            /* TODO: this is slow. Use RSS hash in the future */
+            /* XXX: this is slow. Use RSS hash in the future */
             miniflow_extract(&packets[i]->ofpbuf, md, &key.flow);
 
             if (hash_act->hash_alg == OVS_HASH_ALG_L4) {
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index b45e367..6ee9803 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -64,7 +64,7 @@ static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 20);
 #define MBUF_SIZE(mtu)       (MTU_TO_MAX_LEN(mtu) + (512) + \
                              sizeof(struct rte_mbuf) + RTE_PKTMBUF_HEADROOM)
 
-/* TODO: mempool size should be based on system resources. */
+/* XXX: mempool size should be based on system resources. */
 #define NB_MBUF              (4096 * 64)
 #define MP_CACHE_SZ          (256 * 2)
 #define SOCKET0              0
@@ -74,7 +74,7 @@ static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 20);
 #define NIC_PORT_RX_Q_SIZE 2048  /* Size of Physical NIC RX Queue, Max (n+32<=4096)*/
 #define NIC_PORT_TX_Q_SIZE 2048  /* Size of Physical NIC TX Queue, Max (n+32<=4096)*/
 
-/* TODO: Needs per NIC value for these constants. */
+/* XXX: Needs per NIC value for these constants. */
 #define RX_PTHRESH 32 /* Default values of RX prefetch threshold reg. */
 #define RX_HTHRESH 32 /* Default values of RX host threshold reg. */
 #define RX_WTHRESH 16 /* Default values of RX write-back threshold reg. */
@@ -215,7 +215,7 @@ is_dpdk_class(const struct netdev_class *class)
     return class->construct == netdev_dpdk_construct;
 }
 
-/* TODO: use dpdk malloc for entire OVS. infact huge page shld be used
+/* XXX: use dpdk malloc for entire OVS. infact huge page shld be used
  * for all other sengments data, bss and text. */
 
 static void *
@@ -478,7 +478,7 @@ netdev_dpdk_init(struct netdev *netdev_, unsigned int port_no) OVS_REQUIRES(dpdk
     netdev->mtu = ETHER_MTU;
     netdev->max_packet_len = MTU_TO_MAX_LEN(netdev->mtu);
 
-    /* TODO: need to discover device node at run time. */
+    /* XXX: need to discover device node at run time. */
     netdev->socket_id = SOCKET0;
 
     netdev->dpdk_mp = dpdk_mp_get(netdev->socket_id, netdev->mtu);
@@ -569,7 +569,7 @@ netdev_dpdk_get_config(const struct netdev *netdev_, struct smap *args)
 
     ovs_mutex_lock(&dev->mutex);
 
-    /* TODO: Allow to configure number of queues. */
+    /* XXX: Allow to configure number of queues. */
     smap_add_format(args, "configured_rx_queues", "%u", netdev_->n_rxq);
     smap_add_format(args, "configured_tx_queues", "%u", netdev_->n_rxq);
     ovs_mutex_unlock(&dev->mutex);
diff --git a/ofproto/bundles.c b/ofproto/bundles.c
index 9904465..ddc74c6 100644
--- a/ofproto/bundles.c
+++ b/ofproto/bundles.c
@@ -143,7 +143,7 @@ ofp_bundle_open(struct ofconn *ofconn, uint32_t id, uint16_t flags)
         return OFPERR_OFPBFC_BAD_ID;
     }
 
-    /* TODO: Check the limit of open bundles */
+    /* XXX: Check the limit of open bundles */
 
     bundle = ofp_bundle_create(id, flags);
     bundle->state = BS_OPEN;
@@ -198,7 +198,7 @@ ofp_bundle_commit(struct ofconn *ofconn, uint32_t id, uint16_t flags)
         return OFPERR_OFPBFC_BAD_FLAGS;
     }
 
-    /* TODO: actual commit */
+    /* XXX: actual commit */
 
     return OFPERR_OFPBFC_MSG_UNSUP;
 }
-- 
1.8.1.2




More information about the dev mailing list