[ovs-dev] [PATCH v2 0/2] Make <linux/openvswitch.h> better from userspace

Jesse Gross jesse at nicira.com
Mon Aug 4 17:56:24 UTC 2014


On Fri, Aug 1, 2014 at 9:36 PM, Ben Pfaff <blp at nicira.com> wrote:
> The <linux/openvswitch.h> header is confusing from userspace, because it
> needs to be included on all our platforms yet it has to match upstream
> Linux with all of the baggage that carries.  This series tries to improve
> on the situation.

I'm happy enough with this approach for the time being. (I suspect
that if we ever have really native support on other platforms, such as
the FreeBSD kernel, then they would want us to use their preferred
communication mechanism as Linux would in the reverse situation. We
can address that if it becomes a problem in the future though.)

Acked-by: Jesse Gross <jesse at nicira.com>

The only minor suggestion that I have is make the notice about
odp-netlink.h being a generated file more prominent. On my editor it
blends in with the copyright message so some extra blank lines in
between the two would likely help somewhat.



More information about the dev mailing list