[ovs-dev] [PATCH v2 0/2] Make <linux/openvswitch.h> better from userspace

Ben Pfaff blp at nicira.com
Mon Aug 4 18:30:35 UTC 2014


On Mon, Aug 04, 2014 at 10:56:24AM -0700, Jesse Gross wrote:
> On Fri, Aug 1, 2014 at 9:36 PM, Ben Pfaff <blp at nicira.com> wrote:
> > The <linux/openvswitch.h> header is confusing from userspace, because it
> > needs to be included on all our platforms yet it has to match upstream
> > Linux with all of the baggage that carries.  This series tries to improve
> > on the situation.
> 
> I'm happy enough with this approach for the time being. (I suspect
> that if we ever have really native support on other platforms, such as
> the FreeBSD kernel, then they would want us to use their preferred
> communication mechanism as Linux would in the reverse situation. We
> can address that if it becomes a problem in the future though.)

I agree.

Open vSwitch wants an extensible communication protocol.  Windows
doesn't appear to have a native one.  I don't know about FreeBSD, but
if does then fitting OVS into that might make sense.

> Acked-by: Jesse Gross <jesse at nicira.com>

Thanks.

> The only minor suggestion that I have is make the notice about
> odp-netlink.h being a generated file more prominent. On my editor it
> blends in with the copyright message so some extra blank lines in
> between the two would likely help somewhat.

I added three blank lines.



More information about the dev mailing list