[ovs-dev] [PATCH] dpif-provider: Get rid of redundant operations.

Ben Pfaff blp at nicira.com
Mon Aug 4 20:01:26 UTC 2014


On Tue, Jul 15, 2014 at 04:09:45PM -0700, Ben Pfaff wrote:
> The dpif provider 'operate' call duplicates all of the features available
> from the 'flow_put', 'flow_del', and 'execute' calls, yielding redundant
> code in providers that support both mechanisms.  This change drops the
> latter calls in favor of making every dpif provider support 'operate'.
> The result is code that is overall less duplicative.
> 
> It might make sense to do the same with flow_get but so far 'operate'
> doesn't support flow_get.
> 
> Signed-off-by: Ben Pfaff <blp at nicira.com>

It'd be nice to get this reviewed.  I think it's a nice code cleanup.



More information about the dev mailing list