[ovs-dev] [PATCH] Add include/odp-netlink.h to build instructions in INSTALL.Windows
shettyg at nicira.com
Tue Aug 5 14:46:47 UTC 2014
On Tue, Aug 5, 2014 at 12:50 AM, Nithin Raju <nithin at vmware.com> wrote:
> Since commit 837eefc7 (Do not seemingly #include Linux-specific
> headers on other platforms), openvswitch.h is being auto-generated
> as include/odp-netlink.h.
> On Windows, the auto-generated files are explicitly built. In this
> change, we update the list of auto-generated files to also refer
> to include/odp-netlink.h.
Looks like, when BUILD.Windows was changed to INSTALL.Windows, it lost
You should now be doing just a 'make' (and not pick and choose
executables and files).
Would you add back the couple of lines lost from BUILD.Windows?
You will also need a Signed-off-by.
(If you prefer that I do it, let me know).
> INSTALL.Windows | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/INSTALL.Windows b/INSTALL.Windows
> index b048134..e0543e7 100644
> --- a/INSTALL.Windows
> +++ b/INSTALL.Windows
> @@ -65,7 +65,8 @@ or from a distribution tar ball.
> * Run make for the ported executables in the top source directory, e.g.:
> - % make lib/vswitch-idl.h lib/vtep-idl.h ofproto/ipfix-entities.def
> + % make lib/vswitch-idl.h lib/vtep-idl.h ofproto/ipfix-entities.def \
> + include/odp-netlink.h
> % make ovsdb/ovsdb-server.exe ovsdb/ovsdb-tool.exe ovsdb/ovsdb-client.exe \
> utilities/ovs-vsctl.exe utilities/ovs-ofctl.exe \
> utilities/ovs-dpctl.exe vswitchd/ovs-vswitchd.exe \
> dev mailing list
> dev at openvswitch.org
More information about the dev