[ovs-dev] [PATCH v3 3/8] lib/ovs-atomic: Require memory_order be constant.

Ben Pfaff blp at nicira.com
Tue Aug 5 18:07:44 UTC 2014


On Thu, Jul 31, 2014 at 03:21:49PM -0700, Jarno Rajahalme wrote:
> Compiler implementations may provide sub-optimal support for a
> memory_order passed in as a run-time value (ref.
> https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html).
> 
> Document that OVS atomics require the memory order to be passed in as
> a compile-time constant.
> 
> It should be noted, however, that when inlining is disabled (i.e.,
> compiling without optimization) even compile-time constants may be
> passed as run-time values to (non-inlined) functions.
> 
> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list