[ovs-dev] [PATCH] datapath-windows: Move and Rename files

Samuel Ghinet sghinet at cloudbasesolutions.com
Wed Aug 6 15:58:38 UTC 2014


Thanks Ben for the suggestion!

I'm quite new to sending patches via mailing lists, so I am bit left handed :)
I think I will send replies for this, renaming [PATCH] to e.g. [PATCH 01 / 15]

Thanks!
Sam
________________________________________
From: Ben Pfaff [blp at nicira.com]
Sent: Wednesday, August 06, 2014 6:04 PM
To: Samuel Ghinet
Cc: dev at openvswitch.org
Subject: Re: [ovs-dev] [PATCH] datapath-windows: Move and Rename files

On Wed, Aug 06, 2014 at 11:00:28AM +0000, Samuel Ghinet wrote:
> Move and rename files:
>
> 1. Remove "Ovs" prefixes. There is no reason to have them.
> 2. Create directories and Visual Studio filters to represent them:
> * Core:        anything that is "generic", that might be used anywhere in code, etc.
> * Hyper-v:    functionality for Hyper-V Switch, Hyper-V Nics, Hyper-V Ports, OIDs
> * OpenFlow: the kernel part of the OpenFlow implementation: Datapath, Flows, Ports, Actions.
> * Protocol:    net protocols: ethernet, ip checksuming, tcp, etc.
> * Transfer:    functionalities for NBLs, NB, ingress path, tunneling
> * Winetlink:    IOCTLs, packet queuing to userspace, windows netlink protocol.
>
> Also changed the "#include"-s in the files to acomodate this change.

Hi Samuel.

I see that you have submitted several patches.  Probably, at least some
of these patches depend on others, so that they have to be applied in a
particular order.  If that is the case, then the patches should be
numbered and sent as part of a single email thread.  The "git
send-email" program can do that automatically for you.  (It will also
send each patch exactly once.  I see multiple postings of some of your
patches, without version numbers, which makes it difficult to tell
whether the two posts are the same or different.)

I'll wait for reviews.



More information about the dev mailing list