[ovs-dev] [PATCH v7] Extend OVS IPFIX exporter to export tunnel headers
blp at nicira.com
Thu Aug 7 20:19:21 UTC 2014
On Thu, Aug 07, 2014 at 06:20:41AM +0000, Wenyu Zhang wrote:
> > > I'm not sure why tnl_xlate_init() has this new code:
> > > /* The tp_src and tp_dst members in flow_tnl are set to be always
> > > * wildcarded, not to unwildcard them here. */
> > > wc->masks.tunnel.tp_src = 0;
> > > wc->masks.tunnel.tp_dst = 0; Does it have any visible
> > > effect? It appears to me that these fields are already 0, as initialized by the caller.
> > Yes, the caller has initialized the whole data strusture in the
> > existent codes. But we think that we should set the two fileds as 0
> > obviously in this function, to avoid potential issue if it is called
> > by other callers in future.
> OK, can you please submit that as a separate patch since it is a logically separate change?
> Wenyu: The tp_src and tp_dst is new added fields in this patch. I am afraid that it is not a good idea to separate it in another patch.
I missed that.
Thanks, please keep this change in this patch then.
More information about the dev