[ovs-dev] [PATCH] datapath: Refactor action alloc and copy api.

Jesse Gross jesse at nicira.com
Fri Aug 8 02:21:52 UTC 2014


On Thu, Aug 7, 2014 at 12:51 PM, Pravin B Shelar <pshelar at nicira.com> wrote:
> There are two separate API to allocate and copy actions list. Anytime
> OVS needs to copy action list, it needs to call both functions.
> Following patch moves action allocation to copy function to avoid
> code duplication.
>
> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>

This introduces a warning:

  CC [M]  /home/jesse/openvswitch/datapath/linux/datapath.o
/home/jesse/openvswitch/datapath/linux/datapath.c: In function
‘ovs_flow_cmd_set’:
/home/jesse/openvswitch/datapath/linux/datapath.c:1094:1: warning: the
frame size of 1256 bytes is larger than 1024 bytes
[-Wframe-larger-than=]
 }

This is essentially undoing commit
1d2a1b5f5252e4c6ce8bbf8d91ca27aba52496e6 (datapath: Factor out
allocation and verification of actions.), which was supposed to avoid
this problem. It's actually not a real problem but the warning is
annoying.



More information about the dev mailing list