[ovs-dev] [PATCH] odp-netlink.h: Autogenerate a version of odp-netlink for windows kernel.

Samuel Ghinet sghinet at cloudbasesolutions.com
Fri Aug 8 17:16:11 UTC 2014


[QUOTE]I posted patches for such a solution a few months back.  Jesse rejected
this approach because it caused differences between openvswitch.h
in-tree and in upstream Linux.
[/QUOTE]
The alternative would be to simply use a separate "openvswitch.h" for windows.
This will add the issue of "duplication" of common stuff (as the enums), but the end result will turn out clear, and I don't think it would be hard to maintain after all.

Sam
________________________________________
From: Ben Pfaff [blp at nicira.com]
Sent: Friday, August 08, 2014 7:42 PM
To: Samuel Ghinet
Cc: dev at openvswitch.org
Subject: Re: [ovs-dev] [PATCH] odp-netlink.h: Autogenerate a version of odp-netlink for windows kernel.

On Fri, Aug 08, 2014 at 02:40:52PM +0000, Samuel Ghinet wrote:
> I've got an idea, tell me what you think:
> We could replace "openvswitch.h" on both platforms with something more generic and platform independent.
> This would hold, say, the enum constants and msg constants. The platform-independent "openvswitch.h" must not #include any header.

I posted patches for such a solution a few months back.  Jesse rejected
this approach because it caused differences between openvswitch.h
in-tree and in upstream Linux.



More information about the dev mailing list