[ovs-dev] [PATCH] odp-netlink.h: Autogenerate a version of odp-netlink for windows kernel.

Samuel Ghinet sghinet at cloudbasesolutions.com
Fri Aug 8 18:03:38 UTC 2014


[QUOTE]If the transformation scripts become hard to maintain, we'll do
something else.[/QUOTE]
The script method still doesn't sound awesome.

let's see... can we enclose the #include-s of openvswitch.h within an "#ifndef _WIN32"?
This way, we could #include openvswitch.h on windows.
And, if we need to, we may add an implementation-defined openvswitch-windows.h on windows, where typedefs would be used - if needed - and provide some additional documentational comments.

Sam
________________________________________
From: Ben Pfaff [blp at nicira.com]
Sent: Friday, August 08, 2014 8:47 PM
To: Samuel Ghinet
Cc: dev at openvswitch.org
Subject: Re: [ovs-dev] [PATCH] odp-netlink.h: Autogenerate a version of odp-netlink for windows kernel.

On Fri, Aug 08, 2014 at 05:16:11PM +0000, Samuel Ghinet wrote:
> [QUOTE]I posted patches for such a solution a few months back.  Jesse rejected
> this approach because it caused differences between openvswitch.h
> in-tree and in upstream Linux.
> [/QUOTE]
> The alternative would be to simply use a separate "openvswitch.h" for windows.
> This will add the issue of "duplication" of common stuff (as the enums), but the end result will turn out clear, and I don't think it would be hard to maintain after all.

If the transformation scripts become hard to maintain, we'll do
something else.



More information about the dev mailing list