[ovs-dev] [PATCH v2 8/8] datapath: Allow masks for set actions.

[Jesse Gross]

On Fri, Aug 8, 2014 at 1:28 PM, Jarno Rajahalme <jrajahalme at nicira.com> wrote:
> On Aug 5, 2014, at 10:57 AM, Jesse Gross <jesse at nicira.com> wrote:
>
>> On Fri, Jul 18, 2014 at 8:15 AM, Jarno Rajahalme <jrajahalme at nicira.com> wrote:
>>> On May 8, 2014, at 1:27 PM, Jesse Gross <jesse at nicira.com> wrote:
>> One difficulty that comes to mind is that for tunnel operations we
>> just set a pointer into the flow, which can be difficult for masks
>> since there isn't really anywhere to write the masked result to.
>> However, since we are already converting the tunnel mask actions at
>> flow setup and the initial state is known, one thought that comes to
>> mind is simply converting masked actions to non-masked during the
>> conversion.
>>
>> I'm just trying to see if we can avoid transferring this complexity to
>> userspace.
>>
>
> The tunnel key is already a special case for the input/output issue referenced above, also for userspace. Set tunnel action is triggered for tunnel output only, i.e. even if tunnel ID is set, it has no effect unless the packet is output to a tunnel port.  think leaving the set tunnel action out of the masked set action is not making this difference any worse.

OK, that's fine.