[ovs-dev] [PATCH v4 1/4] lib/odp: Masked set action execution and printing.

Jesse Gross jesse at nicira.com
Mon Aug 11 22:46:45 UTC 2014


On Mon, Aug 11, 2014 at 9:14 AM, Jarno Rajahalme <jrajahalme at nicira.com> wrote:
> diff --git a/tests/odp.at b/tests/odp.at
> index e725f70..58e3ff1 100644
> --- a/tests/odp.at
> +++ b/tests/odp.at
+set(ipv4(src=35.8.2.41/255.255.255.255,dst=172.16.0.20/255.255.255.255,proto=5/0xff,tos=0x80/0,ttl=128/0xff,frag=no/0xff))
> +set(ipv4(src=35.8.2.41/255.255.255.0,dst=172.16.0.20/255.255.255.255,proto=5/0xff,tos=0x80/0xff,ttl=128/0xff,frag=no/0xff))
> +set(ipv4(src=35.8.2.41/255.255.255.0,dst=172.16.0.20/0.0.0.0,proto=5/0,tos=0x80/0xff,ttl=128/0xff,frag=no/0xff))
> +set(ipv4(src=35.8.2.41/0.0.0.0,dst=172.16.0.20/0.0.0.0,proto=5/0,tos=0x80/0x3,ttl=128/0,frag=no/0))
> +set(ipv4(src=35.8.2.41/0.0.0.0,dst=172.16.0.20/0.0.0.0,proto=5/0,tos=0x80/0xfc,ttl=128/0,frag=no/0))
> +set(ipv4(src=35.8.2.41/0.0.0.0,dst=172.16.0.20/0.0.0.0,proto=5/0,tos=0x80/0,ttl=128/0xff,frag=no/0x3))
> +set(ipv4(src=35.8.2.41/0.0.0.0,dst=172.16.0.20/0.0.0.0,proto=5/0,tos=0x80/0,ttl=128/0,frag=no/0xff))

This isn't a review but it seems like it would be nice to have a
shorthand for the common cases where the mask is either fully
wildcarded or fully exact. Maybe we don't print the attribute at all
if it is fully wildcarded and just print the value if it is fully
exact.



More information about the dev mailing list