[ovs-dev] [PATCH] dpif-provider: Get rid of redundant operations.

Ben Pfaff blp at nicira.com
Tue Aug 12 17:00:00 UTC 2014


On Thu, Aug 07, 2014 at 02:25:42PM +1200, Joe Stringer wrote:
> On 16 July 2014 11:09, Ben Pfaff <blp at nicira.com> wrote:
> 
> > The dpif provider 'operate' call duplicates all of the features available
> > from the 'flow_put', 'flow_del', and 'execute' calls, yielding redundant
> > code in providers that support both mechanisms.  This change drops the
> > latter calls in favor of making every dpif provider support 'operate'.
> > The result is code that is overall less duplicative.
> >
> > It might make sense to do the same with flow_get but so far 'operate'
> > doesn't support flow_get.
> >
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> 
> 
> Sorry for the delay on this. It looks good, but it doesn't apply against
> master.

Thanks for the review.  I fixed up the merge conflict and applied this
to master.



More information about the dev mailing list