[ovs-dev] [v2] datapath: Update flow key before recirc

Andy Zhou azhou at nicira.com
Tue Aug 12 17:37:11 UTC 2014


Thanks Pravin and Jarno for the review.  Pushed to master.

On Tue, Aug 12, 2014 at 9:47 AM, Pravin Shelar <pshelar at nicira.com> wrote:
> On Mon, Aug 11, 2014 at 3:36 PM, Andy Zhou <azhou at nicira.com> wrote:
>> When flow key becomes invalid due to push or pop actions, current
>> implementation leaves it as invalid, only rebuild the flow key used
>> for recirculation.
>>
>> This works, but is less efficient in case of multiple recirc
>> actions. Each recirc action will have to re-extract
>> its own flow keys.
>>
>> This patch update the original flow key as soon as the first recirc
>> action is encountered, avoiding expensive flow extract call for any
>> future recirc actions as long as the flow key remains valid.
>>
>> Signed-off-by: Andy Zhou <azhou at nicira.com>
>
> looks good.
>
> Acked-by: Pravin B Shelar <pshelar at nicira.com>



More information about the dev mailing list