[ovs-dev] [PATCH] lib/netlink-protocol.h: Do not include headers for windows kernel build.

Ankur Sharma ankursharma at vmware.com
Tue Aug 12 18:36:27 UTC 2014


Added saurabh's fix to not to include some header files
in lib/netlink-protocol.h not needed by windows driver.

This is a temporary fix to make sure that windows driver can compile.

We are working in parallel on adding netlink support in windows driver
(https://github.com/openvswitch/ovs-issues/issues/18). With netlink support
changes we will get rid of the dependency on lib/netlink-protocol.h.

Testing:
1. Verified make distcheck on linux.
2. Verified that windows driver can compile now.
3. Verified that ping works over vxlan tunnel.

Signed-off-by: Ankur Sharma <ankursharma at vmware.com>
Co-authored-by: Saurabh Shah <ssaurabh at vmware.com>
Tested-by: Ankur Sharma <ankursharma at vmware.com>
Reported-by: Alin Serdean <aserdean at cloudbasesolutions.com>
Reported-at: https://github.com/openvswitch/ovs-issues/issues/21
---
 lib/netlink-protocol.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lib/netlink-protocol.h b/lib/netlink-protocol.h
index 8938055..c3e8aa0 100644
--- a/lib/netlink-protocol.h
+++ b/lib/netlink-protocol.h
@@ -29,9 +29,15 @@
  * on other platforms it directly defines the structures and macros itself.
  */
 
+/* This file is included by windows driver as well (as of now).
+ * It does not have access to following header files,
+ * hence do not include them for windows driver.
+ */
+#ifndef OVS_WIN_DP
 #include <stdint.h>
 #include <sys/socket.h>
 #include "util.h"
+#endif
 
 #ifdef HAVE_NETLINK
 #include <linux/netlink.h>
-- 
1.9.1




More information about the dev mailing list