[ovs-dev] [PATCH] ofp-errors: Use EXT-444 extension error codes for properties in OF1.3.

[Alex Wang]

Looks good to me,


On Mon, Aug 11, 2014 at 2:36 PM, Ben Pfaff <blp at nicira.com> wrote:

> These error codes are proposed in the ONF extensibility working group as an
> OpenFlow 1.3 extension.
>
> Error codes are also proposed for the other three "bad property" error
> codes, but those already have standardized OpenFlow 1.3 error codes and the
> proposal says that implementations should use the standard ones.
>
> ONF-JIRA: EXT-444.
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
>  include/openflow/openflow-common.h |    3 +++
>  lib/ofp-errors.h                   |   12 ++++++------
>  2 files changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/include/openflow/openflow-common.h
> b/include/openflow/openflow-common.h
> index 05d5368..3a11725 100644
> --- a/include/openflow/openflow-common.h
> +++ b/include/openflow/openflow-common.h
> @@ -98,8 +98,11 @@ enum ofp_version {
>   *
>   *    - ONF_VENDOR_ID is being used within the ONF "extensibility" working
>   *      group to identify extensions being proposed for standardization.
> + *
> + * The list is sorted numerically.
>   */
>  #define OF_VENDOR_ID    0
> +#define HPL_VENDOR_ID   0x000004EA /* HP Labs. */
>  #define NX_VENDOR_ID    0x00002320 /* Nicira. */
>  #define ONF_VENDOR_ID   0x4f4e4600 /* Open Networking Foundation. */
>
> diff --git a/lib/ofp-errors.h b/lib/ofp-errors.h
> index e32b751..643fa72 100644
> --- a/lib/ofp-errors.h
> +++ b/lib/ofp-errors.h
> @@ -557,22 +557,22 @@ enum ofperr {
>       * [Known as OFPTFFC_BAD_ARGUMENT in OF1.3.] */
>      OFPERR_OFPBPC_BAD_VALUE,
>
> -    /* OF1.4+(14,3).  Can't handle this many properties. */
> +    /* HPL1.3(4443), OF1.4+(14,3).  Can't handle this many properties. */
>      OFPERR_OFPBPC_TOO_MANY,
>
> -    /* OF1.4+(14,4).  A property type was duplicated. */
> +    /* HPL1.3(4444), OF1.4+(14,4).  A property type was duplicated. */
>      OFPERR_OFPBPC_DUP_TYPE,
>
> -    /* OF1.4+(14,5).  Unknown experimenter id specified. */
> +    /* HPL1.3(4445), OF1.4+(14,5).  Unknown experimenter id specified. */
>      OFPERR_OFPBPC_BAD_EXPERIMENTER,
>
> -    /* OF1.4+(14,6).  Unknown exp_type for experimenter id. */
> +    /* HPL1.3(4446), OF1.4+(14,6).  Unknown exp_type for experimenter id.
> */
>      OFPERR_OFPBPC_BAD_EXP_TYPE,
>
> -    /* OF1.4+(14,7).  Unknown value for experimenter id. */
> +    /* HPL1.3(4447), OF1.4+(14,7).  Unknown value for experimenter id. */
>      OFPERR_OFPBPC_BAD_EXP_VALUE,
>
> -    /* OF1.4+(14,8).  Permissions error. */
> +    /* HPL1.3(4448), OF1.4+(14,8).  Permissions error. */
>      OFPERR_OFPBPC_EPERM,
>
>  /* ## -------------------- ## */
> --
> 1.7.10.4
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>