[ovs-dev] WINDOWS userspace build broken

[Ben Pfaff]

Thank you for the reviews.  I'll apply this to master in a minute.

On Tue, Aug 12, 2014 at 07:01:53PM +0000, Alin Serdean wrote:
> Thanks for the quick fix Ben, I also tested it just to make sure everything is in place.
> 
> Alin.
> 
> -----Mesaj original-----
> De la: Ben Pfaff [mailto:bpfaff at vmware.com] 
> Trimis: Tuesday, August 12, 2014 9:45 PM
> C?tre: Alin Serdean
> Cc: dev at openvswitch.org
> Subiect: Re: WINDOWS userspace build broken
> 
> On Tue, Aug 12, 2014 at 05:39:21PM +0000, Alin Serdean wrote:
> > c:\temp\12_08_2014\ovs\lib\ofp-actions.h(465) : error C2229: struct 
> > 'ofpact_nest ' has an illegal zero-sized array
> > make[2]: *** [lib/bundle.lo] Error 1
> > make[2]: Leaving directory `/c/temp/12_08_2014/ovs'
> > make[1]: *** [all-recursive] Error 1
> > make[1]: Leaving directory `/c/temp/12_08_2014/ovs'
> > make: *** [all] Error 2
> > 
> > Expanding the problem a bit:
> > struct ofpact_nest {
> >     struct ofpact ofpact;
> >     uint8_t pad[PAD_SIZE(sizeof(struct ofpact), OFPACT_ALIGNTO)];
> >     struct ofpact actions[];
> > };
> > Means PAD_SIZE(sizeof(struct ofpact), OFPACT_ALIGNTO) turns out to be 
> > 0 (https://urldefense.proofpoint.com/v1/url?u=http://msdn.microsoft.com/en-us/library/0scy7z2d.aspx&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=7aZ2QNtnIqKBFiZ8gj5w6gylt7IGfJ8QJRUkgBxeSa8%3D%0A&m=maHSXdVpT7UFIF59mR%2FoMVEV18pfExLSRAEllcegU7E%3D%0A&s=165db0e49697400ebec88f0a447cec2eb49e9b8eef660ee0711d37e708e2d668 ).
> 
> Thank you for the report.  I sent out a fix:
>         http://openvswitch.org/pipermail/dev/2014-August/043963.html
> Will you review it?  Thanks.
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev