[ovs-dev] datapath-windows: Renaming files proposal

Samuel Ghinet sghinet at cloudbasesolutions.com
Wed Aug 13 15:29:07 UTC 2014


Nithin,

Reasonable. I was actually thinking that if I want to remove Ovs-prefixes from all files except this one, some people may not agree with this small inconsistency :)

However, I would remove "Ovs" from OvsPub.h and OvsNetlink.h.
Would that be ok to you?

Sam
________________________________________
From: Nithin Raju [nithin at vmware.com]
Sent: Wednesday, August 13, 2014 6:15 PM
To: Samuel Ghinet
Cc: dev at openvswitch.org
Subject: Re: [ovs-dev] datapath-windows: Renaming files proposal

Sam,
OvsDpInterface.h is basically the OVS datapath's interface. It is being generated in a separate directory - sort of public for the datapath - to be sure. I'm inclined to leave the Ovs keyword alone for this 'OVS interface' file. Is that reasonable?

thanks,
Nithin


On Aug 13, 2014, at 8:11 AM, Samuel Ghinet <sghinet at cloudbasesolutions.com>
 wrote:

> Hello guys,
>
> Just to make sure that everyone agrees to this.
> I want to add a commit in which to rename all files, by removing the prefix Ovs.
> E.g. OvsActions.c -> Actions.c
>
> Since there is no use in having the prefix "Ovs", and removing it may improve clarity. (there was a discussion on this on the ML)
>
> A slight complication has appeared, with the advent of OvsDpInterface.h, which is generated.
> If I am to remove the Ovs-prefix from the others, I would remove it from OvsDpInterface.h as well, which means renaming it in the .gitignore, automake.mk (in datapath-windows\include) as well.
>
> I just want to make sure that everyone is ok with this, before I do the commit :)
>
> Sam
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=ubrOpIWavCMqX4l4j1LEVpTfDj%2FD5Qyn8KCoJIBGvzo%3D%0A&m=VEHXb76F4IOqrluamPp8Oz8WsFzGBuPsZ1DZHLAhIic%3D%0A&s=07301ed1c1ab2023fcd9c2d06ec980d29a1af54a143c379a229a7d3463ea0a6f




More information about the dev mailing list