[ovs-dev] [PATCHv2] dpif: Support flow_get in dpif_operate().

Ben Pfaff blp at nicira.com
Wed Aug 13 16:52:57 UTC 2014


On Wed, Aug 13, 2014 at 12:53:31PM +1200, Joe Stringer wrote:
> This cleans up the dpif interface to make it more consistent with the
> other dpif operations, and allows flows to be fetched in batches.
> 
> Signed-off-by: Joe Stringer <joestringer at nicira.com>

Thanks.  I like it.

I'd move this memset() in the error case in dpif_linux_operate__():
+            if (op->error) {
+                memset(get->flow, 0, sizeof *get->flow);
+            }
into the DPIF_OP_FLOW_GET error case in dpif_operate(), so that all of
the dpifs can take advantage of this logic (as the other DPIF_OP_*
cases do).

The comment in dpif.h says that DPIF_FLOW_BUFSIZE is a mandatory
size.  I don't think the implementations rely on that.

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list