[ovs-dev] [DPDK Upcalls v2 3/3] dpif-netdev: Streamline miss handling.

Ethan Jackson ethan at nicira.com
Thu Aug 14 00:22:00 UTC 2014


> In ofproto-dpif-upcall.c, there are two blank lines above upcall_cb
> (horrors!).

I'm experimenting with a new form of avant-garde post-post-post-modern
dadaist syntax formatting.  Only those with the most discerning taste
could possibly comprehend its momentous implications.

> Did you test with megaflows disabled, by the way?  I am not sure
> whether all-1-bits is an appropriate wildcard mask.

There's a unit test which catches it.

Everything else made sense so I change the code accordingly.

Ethan



More information about the dev mailing list