[ovs-dev] datapath-windows: Renaming files proposal

Samuel Ghinet sghinet at cloudbasesolutions.com
Thu Aug 14 00:32:11 UTC 2014


I meant,
tell me whether you prefer Eth.h or Ethernet.h
I have a slight preference for Ethernet.h, but it's no big deal to me.

Sam
________________________________
From: Samuel Ghinet
Sent: Thursday, August 14, 2014 3:21 AM
To: Nithin Raju; Ankur Sharma; Saurabh Shah
Cc: dev at openvswitch.org
Subject: RE: [ovs-dev] datapath-windows: Renaming files proposal

Okay, so I'm gonna make a patch which will nuke the Ovs prefix of the following files:

OvsActions.c -> Actions.c
OvsAtomic.h -> Atomic.h
OvsBufferMgmt.c -> BufferMgmt.c
OvsBufferMgmt.h -> BufferMgmt.h
OvsChecksum.c -> Checksum.c
OvsChecksum.h -> Checksum.h
OvsDebug.c -> Debug.c
OvsDebug.h -> Debug.h
OvsDriver.c -> Driver.c
OvsEth.h -> Ethernet.h [TELL ME IF YOU PREFER "Eth.h"]
OvsEvent.c -> Event.c
OvsEvent.h -> Event.h
OvsFlow.c -> Flow.c
OvsFlow.h -> Flow.h
OvsIoctl.c -> Ioctl.c
OvsIoctl.h -> Ioctl.h
OvsIpHelper.c -> IpHelper.c
OvsIpHelper.h -> IpHelper.h
OvsJhash.c -> Jhash.c
OvsJhash.h -> Jhash.h
OvsNetProto.h -> NetProto.h
OvsOid.c -> Oid.c
OvsOid.h -> Oid.h
OvsPacketIO.c -> PacketIO.c
OvsPacketIO.h -> PacketIO.h
OvsPacketParser.c -> PacketParser.c
OvsPacketParser.h -> PacketParser.h
OvsSwitch.c -> Switch.c
OvsSwitch.h -> Switch.h
OvsTunnel.c -> Tunnel.c
OvsTunnel.h -> Tunnel.h
OvsTunnelFilter.c -> TunnelFilter.c
OvsTunnelIntf.h -> TunnelIntf.h
OvsTypes.h -> Types.h
OvsUser.c -> User.c
OvsUser.h -> User.h
OvsUtil.c -> Util.c
OvsUtil.h -> Util.h
OvsVport.c -> Vport.c
OvsVport.h -> Vport.h
OvsVxlan.c -> Vxlan.c
OvsVxlan.h -> Vxlan.h

OvsNetlink.h -> Netlink.h
OvsPub.h -> Pub.h

The following will be left intact:
OvsDpInterface.h
Because it is a userspace interaction file and it is a generated file.
Whether someone believes the userspace interaction files should be marked by a different prefix than Ovs, or not marked at all, this would be a different topic to be discussed some other time. In this "remove Ovs prefix" commit, OvsDpInterface.h will not be renamed.

Everyone ok with this?
Sam

________________________________
From: Nithin Raju [nithin at vmware.com]
Sent: Thursday, August 14, 2014 2:36 AM
To: Ankur Sharma; Saurabh Shah; Samuel Ghinet
Cc: dev at openvswitch.org
Subject: RE: [ovs-dev] datapath-windows: Renaming files proposal

Sam and Alin are of the opinion that we should nuke 'Ovs' in all files except OvsDpInterface.h.

As regards to removing 'Ovs' in OvsPub.h, I said the following to Sam.


> However, I would remove "Ovs" from OvsPub.h and OvsNetlink.h.

> Would that be ok to you?



Totally fine!



OvsPub.h is the legacy interface and will be nuked as soon as the netlink based interface is ready. OvsNetlink.h will be moved back within ovsext since it is not a 'shared file'. Ankur is working on that. Yes, getting rid of 'Ovs' from OvsNetlink is fine.

Thanks!
-- Nithin

From: Ankur Sharma
Sent: Wednesday, August 13, 2014 4:31 PM
To: Saurabh Shah; Samuel Ghinet; Nithin Raju
Cc: dev at openvswitch.org
Subject: RE: [ovs-dev] datapath-windows: Renaming files proposal

Correct, i think userspace interaction headers should have Ovs prefix.

Regards,
Ankur
________________________________
From: Saurabh Shah
Sent: Wednesday, August 13, 2014 4:28 PM
To: Ankur Sharma; Samuel Ghinet; Nithin Raju
Cc: dev at openvswitch.org<mailto:dev at openvswitch.org>
Subject: Re: [ovs-dev] datapath-windows: Renaming files proposal

If that’s the case, we should also keep the ‘Ovs’ prefix for OvsPub.h. :)

Thanks!
Saurabh

From: Ankur Sharma <ankursharma at vmware.com<mailto:ankursharma at vmware.com>>
Date: Wednesday, August 13, 2014 at 4:20 PM
To: Saurabh Shah <ssaurabh at vmware.com<mailto:ssaurabh at vmware.com>>, Samuel Ghinet <sghinet at cloudbasesolutions.com<mailto:sghinet at cloudbasesolutions.com>>, Nithin Raju <nithin at vmware.com<mailto:nithin at vmware.com>>
Cc: "dev at openvswitch.org<mailto:dev at openvswitch.org>" <dev at openvswitch.org<mailto:dev at openvswitch.org>>
Subject: RE: [ovs-dev] datapath-windows: Renaming files proposal

Hi,

The reason we decided to keep Ovs with DpInterface was because this file defines the interface with ovs userspace, i.e it has a different semantics from other header files in ovsext.
I would prefer keeping the Ovs prefix, but its fine if you think it should be renamed.

Thanks.

Regards,
Ankur
________________________________________
From: dev <dev-bounces at openvswitch.org<mailto:dev-bounces at openvswitch.org>> on behalf of Saurabh Shah <ssaurabh at vmware.com<mailto:ssaurabh at vmware.com>>
Sent: Wednesday, August 13, 2014 3:39 PM
To: Samuel Ghinet; Nithin Raju
Cc: dev at openvswitch.org<mailto:dev at openvswitch.org>
Subject: Re: [ovs-dev] datapath-windows: Renaming files proposal

+1 for dropping the 'Ovs' prefix for OvsDpInterface. It is odd to have just one file prefixed with Ovs.

Thanks!
Saurabh

From: Samuel Ghinet <sghinet at cloudbasesolutions.com<mailto:sghinet at cloudbasesolutions.com><mailto:sghinet at cloudbasesolutions.com><mailto:sghinet at cloudbasesolutions.com%3e>>
Date: Wednesday, August 13, 2014 at 8:29 AM
To: Nithin Raju <nithin at vmware.com<mailto:nithin at vmware.com><mailto:nithin at vmware.com><mailto:nithin at vmware.com%3e>>
Cc: "dev at openvswitch.org<mailto:dev at openvswitch.org><mailto:dev at openvswitch.org><mailto:dev at openvswitch.org%3e>" <dev at openvswitch.org<mailto:dev at openvswitch.org><mailto:dev at openvswitch.org><mailto:dev at openvswitch.org%3e>>
Subject: Re: [ovs-dev] datapath-windows: Renaming files proposal

Nithin,

Reasonable. I was actually thinking that if I want to remove Ovs-prefixes from all files except this one, some people may not agree with this small inconsistency :)

However, I would remove "Ovs" from OvsPub.h and OvsNetlink.h.
Would that be ok to you?

Sam
________________________________________
From: Nithin Raju [nithin at vmware.com<mailto:nithin at vmware.com><mailto:nithin at vmware.com><mailto:nithin at vmware.com%3e>]
Sent: Wednesday, August 13, 2014 6:15 PM
To: Samuel Ghinet
Cc: dev at openvswitch.org<mailto:dev at openvswitch.org><mailto:dev at openvswitch.org>
Subject: Re: [ovs-dev] datapath-windows: Renaming files proposal

Sam,
OvsDpInterface.h is basically the OVS datapath's interface. It is being generated in a separate directory - sort of public for the datapath - to be sure. I'm inclined to leave the Ovs keyword alone for this 'OVS interface' file. Is that reasonable?

thanks,
Nithin


On Aug 13, 2014, at 8:11 AM, Samuel Ghinet <sghinet at cloudbasesolutions.com<mailto:sghinet at cloudbasesolutions.com><mailto:sghinet at cloudbasesolutions.com><mailto:sghinet at cloudbasesolutions.com%3e>>
wrote:

Hello guys,

Just to make sure that everyone agrees to this.
I want to add a commit in which to rename all files, by removing the prefix Ovs.
E.g. OvsActions.c -> Actions.c

Since there is no use in having the prefix "Ovs", and removing it may improve clarity. (there was a discussion on this on the ML)

A slight complication has appeared, with the advent of OvsDpInterface.h, which is generated.
If I am to remove the Ovs-prefix from the others, I would remove it from OvsDpInterface.h as well, which means renaming it in the .gitignore, automake.mk (in datapath-windows\include) as well.

I just want to make sure that everyone is ok with this, before I do the commit :)

Sam
_______________________________________________
dev mailing list
dev at openvswitch.org<mailto:dev at openvswitch.org><mailto:dev at openvswitch.org>
https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=ubrOpIWavCMqX4l4j1LEVpTfDj%2FD5Qyn8KCoJIBGvzo%3D%0A&m=VEHXb76F4IOqrluamPp8Oz8WsFzGBuPsZ1DZHLAhIic%3D%0A&s=07301ed1c1ab2023fcd9c2d06ec980d29a1af54a143c379a229a7d3463ea0a6f

_______________________________________________
dev mailing list
dev at openvswitch.org<mailto:dev at openvswitch.org><mailto:dev at openvswitch.org>
https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=pEkjsHfytvHEWufeZPpgqSOJMdMjuZPbesVsNhCUc0E%3D%0A&m=7yzJ1BGzZfWlgeq35UqNHc2YhJbN1S0UZ7vGy0ArYjc%3D%0A&s=8c40d293f3bcb442fc00faaf347e4e8d0c9514f2624fc75a8604f24bff88412f

_______________________________________________
dev mailing list
dev at openvswitch.org<mailto:dev at openvswitch.org>
https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=f6EhnZ0ORGZNt5QbYmRaOxfWfx%2Bqd3KEiPf3%2FYaollU%3D%0A&m=7eOlWXeoqKefE0yDM6S3bvotnX8C4K4wEDOTH7Cuj%2FM%3D%0A&s=6851218affb2a57175b67d8e9bf7688db392ef7f23037e6a8f980c477d09eca3



More information about the dev mailing list