[ovs-dev] [DPDK Upcalls v3 2/3] ofproto: Reorganize in preparation for direct dpdk upcalls.

Ben Pfaff blp at nicira.com
Thu Aug 14 16:49:37 UTC 2014


On Wed, Aug 13, 2014 at 06:46:17PM -0700, Ethan Jackson wrote:
> This patch reorganizes ofproto-dpif in preparation for future patches
> which allow direct upcall processing from dpif-netdev.  The main goals
> are to share as much code as possible between the dpif-linux and
> dpif-netdev upcall paths.  Additionally, to avoid confusing the
> dpif-netdev fast path, the packet processing path should treat packets
> and struct flow's as const.
> 
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

recv_upcalls() calls upcall_receive() and if that fails it jumps to
cleanup to call upcall_uninit().  However, my reading of
upcall_receive() is that in its only failure case the upcall is not
properly initialized to call upcall_uninit().  For example, I believe
that the upcall's xout_initialized member is not initialized at that
point.  I think that this error case should jump to free_dupcall
instead.

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list