[ovs-dev] [PATCH] ofp-actions: Include OFPACT_REG_MOVE in action set

Ben Pfaff blp at nicira.com
Thu Aug 14 20:47:05 UTC 2014


On Thu, Aug 14, 2014 at 10:44:00PM +0200, Thomas Graf wrote:
> Treating OFPACT_REG_MOVE as a "set" action preserves the order of loads
> and moves and allows a load to overwrite a previous move to the same
> register.
> 
> This makes the following work:
> 
> add-group br0 group_id=1234,type=all, \
>               bucket=output:10,move:NXM_NX_REG1[]->NXM_OF_IP_SRC[], \
> 			  bucket=output:11
> add-flow br0 ip actions=load:0xffffffff->NXM_NX_REG1[],group:1234
> 
> Signed-off-by: Thomas Graf <tgraf at noironetworks.com>

Please also rename ofpact_is_set_action() and update its comment to
better reflect what we're doing now.  Also please update ovs-ofctl(8) to
mention the new behavior.  Otherwise I'm happy with this.



More information about the dev mailing list