[ovs-dev] [PATCH 1/4] Add extentions to the standard datapath interface

[Saurabh Shah]

Hi Nithin,

> -----Original Message-----
> From: Nithin Raju
> Sent: Thursday, August 14, 2014 5:56 PM
> To: Saurabh Shah
> Cc: dev at openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 1/4] Add extentions to the standard datapath
> interface
> 
> On Aug 14, 2014, at 5:01 PM, Saurabh Shah <ssaurabh at vmware.com>
>  wrote:
> >> +#define OVS_DEVICE_NAME_USER   TEXT("\\\\.\\OpenVSwitchDevice")
> >> +
> >
> > Should be "OpenvSwitchDevice".
> 
> Sure. I'll change this.
> 
> >> +#ifdef _WIN32
> >> +#include "OvsDpInterfaceExt.h"
> >> +#endif
> >
> > Since we define & control the dp interface, why not just include
> OvsDpInterfaceExt.h directly? (Just like what we used to do earlier by
> including OvsPub.h.)
> 
> If we include OvsDpInterfaceExt.h, we'll have to have a #ifdef _WIN32. IMO,
> it is neater to not do this. One more reason is that, we'll want to generate a
> odp-netlink-ext.h in the future from OvsDpInterfaceExt.h, similar to how we
> generate odp-netlink.h from openvswitch.h.
> 

Writing a wrapper header file just to hide the #ifdef is completely unnecessary. I don't see why anything needs to be autogenerated for interfaces that we define. 

Thanks,
Saurabh

> thanks,
> Nithin