[ovs-dev] [PATCH] datapath-windows: define a OVS_VPORTNO_DEFAULT instead of using 0

Saurabh Shah ssaurabh at vmware.com
Fri Aug 15 02:03:30 UTC 2014


Can your rename OVS_VPORTNO_DEFAULT to something else? Having two defaults with similar name, but different value is confusing.

Thanks,
Saurabh

> -----Original Message-----
> From: Nithin Raju
> Sent: Thursday, August 14, 2014 6:16 PM
> To: Saurabh Shah
> Cc: dev at openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] datapath-windows: define a
> OVS_VPORTNO_DEFAULT instead of using 0
> 
> On Aug 14, 2014, at 4:46 PM, Saurabh Shah <ssaurabh at vmware.com>
>  wrote:
> 
> > $ grep PORT_NO datapath-windows/include/OvsPub.h #define
> > OVS_DEFAULT_PORT_NO 0xffffffff
> 
> I named it the way you had suggested initially, then changed it to
> OVS_VPORTNO_DEFAULT, since other constants in the file were named like
> OVS_<XYZ>_DEFAULT_INDEX, OVS_<XYZ>_START, OVS_<XYZ>_END etc :)
> 
> Ok, I don't mind breaking the convention here. Let me know.
> 
> thanks,
> Nithin



More information about the dev mailing list