[ovs-dev] [PATCH 3/4] datapath-windows: add infrastructure for supporting netlink

[Nithin Raju]

On Aug 14, 2014, at 4:53 PM, Ankur Sharma <ankursharma at vmware.com>
 wrote:
> a. I think we should add the cmd handler installation in following format:
> 
> /* Netlink control family: this is a Windows specific family. */
> NETLINK_CMD nlControlFamilyCmdOps[] = {
>    {OVS_CTRL_CMD_WIN_GET_PID, OvsGetPidCmdHandler, OVS_TRANSACTION_DEV_OP},
>    {OVS_XXX, Ovsxxxxxx, OVS_XXX_DEV_OP},
>    {OVS_YYY, Ovsyyyyyy, OVS_YYY_DEV_OP},
> I think this way the could would be more readable and adding a new cmd handler would be much simpler.

Sure, this makes sense. Commands can fit in one line, and potentially there are lot of them.

> b. Same comment for initializing families.
There are fewer families, and they don't fit in one line. I want to let the code be, unless you have a strong opinion.

> c. we should also put family and there commands together.


Sure. This is kind of true today. The control family and the commands are together. When we add commands for other families, I'll put a place holder comment to say where they should be added.

thanks,
Nithin