[ovs-dev] [PATCH 2/4] datapath-windows: Add OvsDatapath.[ch] and OVS_USE_NL_INTERFACE CPP

Nithin Raju nithin at vmware.com
Fri Aug 15 03:28:35 UTC 2014


On Aug 14, 2014, at 5:08 PM, Saurabh Shah <ssaurabh at vmware.com>
 wrote:

> Naming the file OvsIoctl.[ch] seems much clearer to me. I don't know why these files are being renamed. Also, if these are not going to be shared with the userspace, you should drop the Ovs prefix from the file name.

hi Saurabh,
The legacy interface files are still existent in OvsIoctl.[ch]. I called these OvsDatapath.c for two reasons:
1. This is the 'datapath' in the kernel.
2. The code that interfaces with userspace on Linux is called datapath.c.

I don't have strong opinion about file names. I can rename it to OvsIoctl.[ch] once we delete the old ones.

Sure, I'll beat Sam to removing the 'Ovs' prefix for the new files being added :)

-- Nithin


More information about the dev mailing list