[ovs-dev] [PATCH] Use local time for Inf2Cat

Alin Serdean aserdean at cloudbasesolutions.com
Fri Aug 15 16:24:46 UTC 2014


Hi Saurabh,

Thank you for the review.

The issue I was following can be related to the following:
https://connect.microsoft.com/VisualStudio/feedback/details/787203/driver-package-building-problem

Thanks,
Alin.

-----Mesaj original-----
De la: Saurabh Shah [mailto:ssaurabh at vmware.com] 
Trimis: Friday, August 15, 2014 4:57 AM
Către: Alin Serdean; dev at openvswitch.org
Subiect: RE: [PATCH] Use local time for Inf2Cat

On a related note, while I see the log which says its stamping the local time in INF file. The actual DriverVer in the INF remains unchanged. Not sure why.

I don't know what the build problem is. But if it fixes your problem. :)

Acked-by: Saurabh Shah

> -----Original Message-----
> From: dev [mailto:dev-bounces at openvswitch.org] On Behalf Of Alin 
> Serdean
> Sent: Wednesday, August 13, 2014 8:15 AM
> To: dev at openvswitch.org
> Subject: [ovs-dev] [PATCH] Use local time for Inf2Cat
> 
> Issue: cannot build properly when local date differs from UTC date.
> 
> Since Stampinf stamps the driver inf file with the local date set the 
> Inf2Cat to use local date as well.
> 
> Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
> ---
>  datapath-windows/Package/package.VcxProj | 20 +++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/datapath-windows/Package/package.VcxProj b/datapath- 
> windows/Package/package.VcxProj index ad2bcc7..0d48163 100644
> --- a/datapath-windows/Package/package.VcxProj
> +++ b/datapath-windows/Package/package.VcxProj
> @@ -78,7 +78,25 @@
>      <VerifyDrivers />
>      <VerifyFlags>133563</VerifyFlags>
>    </PropertyGroup>
> -  <ItemDefinitionGroup>
> +  <ItemDefinitionGroup 
> + Condition="'$(Configuration)|$(Platform)'=='Win8
> Debug|x64'">
> +    <Inf2Cat>
> +      <UseLocalTime>true</UseLocalTime>
> +    </Inf2Cat>
> +  </ItemDefinitionGroup>
> +  <ItemDefinitionGroup 
> + Condition="'$(Configuration)|$(Platform)'=='Win8.1
> Debug|x64'">
> +    <Inf2Cat>
> +      <UseLocalTime>true</UseLocalTime>
> +    </Inf2Cat>
> +  </ItemDefinitionGroup>
> +  <ItemDefinitionGroup 
> + Condition="'$(Configuration)|$(Platform)'=='Win8
> Release|x64'">
> +    <Inf2Cat>
> +      <UseLocalTime>true</UseLocalTime>
> +    </Inf2Cat>
> +  </ItemDefinitionGroup>
> +  <ItemDefinitionGroup 
> + Condition="'$(Configuration)|$(Platform)'=='Win8.1
> Release|x64'">
> +    <Inf2Cat>
> +      <UseLocalTime>true</UseLocalTime>
> +    </Inf2Cat>
>    </ItemDefinitionGroup>
>    <ItemGroup>
>      <!--Inf Include="DriverInf.inv" /-->
> --
> 1.9.0.msysgit.0
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mail
> m an/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=pEkjsHfytv
> HEWufeZPpgqSOJMdMjuZPbesVsNhCUc0E%3D%0A&m=GefJH0yIIPvn5S2uT
> %2F0TG5XqCcOQnkcNx1ieompQQp4%3D%0A&s=a6de4b2ac14ec68951b573d
> bd2eeca15de05467be143a9dc9500fc2a98e98c25



More information about the dev mailing list