[ovs-dev] dpif: Setting vlan tci for qinq

Ben Pfaff blp at nicira.com
Mon Aug 18 15:34:36 UTC 2014


On Mon, Aug 18, 2014 at 06:44:32AM -0400, Thomas F Herbert wrote:
> I have been working on 802.1ad qinq and I have been puzzled by this
> construct in odp-util.c
> where vlan sets are put in the database with a pop, a set of the tci
> into the struct and then a push. I think this is because the push
> vlan is the
> only way to pass a vlan_tci through the dpif to the linux kernel.
> This makes it difficult to implement stacked vlans and I think it is
> the last remaining issue.
> What is the best way to address this while not breaking existing
> VLAN behavior? Should I introduce another action attribute,
> OVS_ACTION_ATTR_SET_VLAN or is there a way to utilize the
> OVS_ACTION_ATTR_SET?

I don't understand the problem.  If you want a second VLAN tag, push
another one.



More information about the dev mailing list