[ovs-dev] [DPDK Upcalls v2 3/3] dpif-netdev: Streamline miss handling.

Ben Pfaff blp at nicira.com
Mon Aug 18 16:58:59 UTC 2014


On Mon, Aug 18, 2014 at 04:44:58PM +1200, Joe Stringer wrote:
> On 13 August 2014 06:24, Ben Pfaff <blp at nicira.com> wrote:
> >
> > dp_netdev_flow_add() goes to some trouble to log matches as if they
> > were provided as datapath flows, even though they aren't.  I think
> > that match_format() would be simpler and probably less confusing.
> 
> 
> In the majority of cases, I agree---however there are a couple of specific
> tests in tests/dpif-netdev.at that would benefit from having datapath flow
> format, as a way to detect whether flow translation is correct or not.
> Can we somehow provide the option to log these in full format?

That sounds unpleasant to me.  If we need the datapath flow format
sometimes, then for me that's a good enough reason to use it all the
time.



More information about the dev mailing list