[ovs-dev] [PATCH 1/2] automake: Add AM_LDFLAGS while linking ovs-vswitchd.

Daniele Di Proietto ddiproietto at vmware.com
Mon Aug 18 17:37:19 UTC 2014


I just sent a patch to the list. Please, let me know if this solves all
the issues.

Thanks,

Daniele

On 8/18/14, 10:31 AM, "Ben Pfaff" <blp at nicira.com> wrote:

>On Mon, Aug 18, 2014 at 10:28:44AM -0700, Gurucharan Shetty wrote:
>> On Mon, Aug 18, 2014 at 9:51 AM, Ben Pfaff <blp at nicira.com> wrote:
>> > On Mon, Aug 18, 2014 at 07:48:10AM -0700, Gurucharan Shetty wrote:
>> >> Commit d73105839 (netdev-dpdk: Move to DPDK 1.7.0) added
>> >> 'vswitchd_ovs_vswitchd_LDFLAGS' in acinclude.m4. This caused the
>> >> created Makefile to use 'vswitchd_ovs_vswitchd_LINK' without
>> >> including 'AM_LDFLAGS'. This causes failure while building
>>ovs-vswitchd
>> >> with external libraries (ex: ovs-vswitchd on Windows with openssl.)
>> >>
>> >> This commit adds 'AM_LDFLAGS' to the new
>>'vswitchd_ovs_vswitchd_LDFLAGS'.
>> >>
>> >> Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
>> >
>> > I didn't review commit d73105839 until now.  I don't think it's wise
>> > to substitute an Automake-owned variable that way.  It's not commonly
>> > done, so it might confuse readers (it would confuse me), and I doubt
>> > that Automake guarantees that it will continue to work.
>> >
>> > I would rather see acinclude.m4 substitute some variable whose name is
>> > not owned by Automake, e.g. DPDK_LDFLAGS, and then in automake.mk
>> > write vswitchd_ovs_vswitchd_LDFLAGS = $(AM_LDFLAGS) $(DPDK_LDFLAGS).
>> >
>> > Does that make sense?
>> Yes, it makes sense. Daniele will be sending an updated patch.
>
>Thanks!
>_______________________________________________
>dev mailing list
>dev at openvswitch.org
>https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/
>listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=MV9BdLjtFIdhBDBaw5z%2BU
>6SSA2gAfY4L%2F1HCy3VjlKU%3D%0A&m=er%2BpksRsWi5vmcquJZcZY%2BUFki7Yh6ELNazjs
>5odJq4%3D%0A&s=86a975c2ecc8b6dbf3f753d416f6e6ec924bc206564908139c3e8ea132c
>7d53b




More information about the dev mailing list