[ovs-dev] [PATCH] acinclude.m4: Do not set vswitchd_ovs_vswitchd_LDFLAGS
shettyg at nicira.com
Mon Aug 18 19:38:34 UTC 2014
On Mon, Aug 18, 2014 at 10:37 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, Aug 18, 2014 at 10:23:55AM -0700, Daniele Di Proietto wrote:
>> Commit d731058395cb used vswitchd_ovs_vswitchd_LDFLAGS to link with DPDK. This
>> made automake ignore AM_LDFLAGS while linking the daemon.
>> This commit explicitly adds AM_LDFLAGS to vswitchd_ovs_vswitchd_LDFLAGS and
>> moves it to vswitchd/automake.mk
>> Reported-by: Gurucharan Shetty <gshetty at nicira.com>
>> Suggested-by: Ben Pfaff <blp at nicira.com>
>> Signed-off-by: Daniele Di Proietto <ddiproietto at vmware.com>
>> Guru, does this properly address the issue?
Yes. Thanks! I applied this to master.
> I like this better. Thanks!
>> We could also put the extra line in vswitchd/automake.mk inside an "if
>> DPDK_NETDEV" block. What do you guys think?
> I don't think an extra 'if' clarifies anything.
> I'll leave it to Guru to apply this, if he's happy with it.
> dev mailing list
> dev at openvswitch.org
More information about the dev