[ovs-dev] [PATCH 1/4 v2] Add extentions to the standard datapath interface

Saurabh Shah ssaurabh at vmware.com
Tue Aug 19 02:10:50 UTC 2014


Hi Ben,

>On Thu, Aug 14, 2014 at 08:35:36PM -0700, Nithin Raju wrote:
>> The datapath interface defined in odp-netlink.h needs some extensions
>> that are platform dependent. Some examples are the name of the
>>communication
>> device on Windows and a set of commands that are specific to Windows.
>> 
>> In this change we define a include/odp-netlink-ext.h to in turn include
>> any platform specific interface extensions.
>> For Windows datapath, the extensions are defined in a new header:
>> datapath-windows/include/OvsDpInterfaceExt.h.
>> 
>> The file odp-netlink-ext.h is not an auto-generated file unlke
>>odp-netlink.h.
>> In the future, we can possibly auto-generate it based on
>>OvsDpInterfaceExt.h.
>> 
>> Also, we define three ioctls in OvsDpInterfaceExt.h:
>> read:     provides an output buffer (mimics a recv)
>> write:    provides an input buffer (mimics a send)
>> transact: provides an input and optionally an output buffer.
>>           (mimics a send followed by recv)
>> 
>> Signed-off-by: Nithin Raju <nithin at vmware.com>
>
>I'm fine with this.  I'd like someone else to review the actual
>Windows-specific bits.

Is there any objection if we directly include OvsDpInterfaceExt.h in
userspace (with the right #ifdefs, of course)? I don't understand why we
would want to auto-generate a file just to include the kernel header file.
This is what the auto-generated file is supposed to look like -

/*
 * Header file to include platform-specific extensions to the standard
 * datapath interface defined in odp-netlink.h.
 */
#ifdef _WIN32
#include "OvsDpInterfaceExt.h"
#endif

Saurabh







More information about the dev mailing list