[ovs-dev] [PATCH 07/15] datapath-windows: Replace Types.h

Samuel Ghinet sghinet at cloudbasesolutions.com
Thu Aug 21 19:26:31 UTC 2014


Okay, got it!

Thanks!
Sam
________________________________________
From: Nithin Raju [nithin at vmware.com]
Sent: Saturday, August 16, 2014 9:38 AM
To: Samuel Ghinet
Cc: dev at openvswitch.org
Subject: Re: [ovs-dev] [PATCH 07/15] datapath-windows: Replace Types.h

On Aug 6, 2014, at 9:11 AM, Samuel Ghinet <sghinet at cloudbasesolutions.com> wrote:

> Replace Types.h
>
> The coding style on windows kernel is to use uppercase for all types. This also applies to builtin types.
> We shouldn't use int64_t, uint64_t, etc. Instead, we should use windows style builtin types: INT64, UINT64, etc.
>
> Also, the new Types.h adds macros for splitting & uniting data of variables of builtin types.
>
> Signed-off-by: Samuel Ghinet <sghinet at cloudbasesolutions.com>


hi Sam,
The reason we defined OvsTypes.h was to make sure that we can compiled what was openvswitch.h earlier, and now is OvsDpInterface.h. There's no plan to use non windows types in the code within ovsext.

So, pls. don't delete the existing contents of OvsTypes.h. If you want to add something, pls. spin up a patch for it and send it over. I'll take a look.

thanks,
Nithin



More information about the dev mailing list