[ovs-dev] [RFC 04/14] revalidator: Protect ukeys with a mutex.

Joe Stringer joestringer at nicira.com
Mon Aug 25 04:30:58 UTC 2014

On 23 August 2014 08:01, Ben Pfaff <blp at nicira.com> wrote:

> On Thu, Aug 21, 2014 at 05:41:59PM +1200, Joe Stringer wrote:
> > Currently, ukeys are protected during revalidator_sweep__() as only one
> > thread accesses the ukey at a time. This is ensured using barriers:
> > all revalidators will be in the GC phase, so they will only access their
> > own ukey collection.
> >
> > A future patch will change the access patterns to allow these ukey
> > collections to be read or modified while a revalidator is garbage
> > collecting it. To protect the ukeys, this patch adds locking on the ukey
> > collection.
> >
> > Signed-off-by: Joe Stringer <joestringer at nicira.com>
> Do we actually explain anywhere that "ukey" means "udpif_key"?

The definition of 'struct udpif_key' refers to the ukeys map in the parent
udpif. I can update the commit log to make this more clear.

> Acked-by: Ben Pfaff <blp at nicira.com>

More information about the dev mailing list