[ovs-dev] [PATCH 3/4] ofproto-dpif-xlate: Drop 'may_learn' parameter from xlate_push_stats().

Ben Pfaff blp at nicira.com
Mon Aug 25 15:55:24 UTC 2014


On Mon, Aug 25, 2014 at 03:07:05PM +1200, Joe Stringer wrote:
> On 23 August 2014 10:47, Ben Pfaff <blp at nicira.com> wrote:
> 
> > Both existing callers calculated 'may_learn' as 'stats->n_packets > 0', so
> > it was redundant.  Because xlate_push_stats() is now entirely a no-op if
> > 'stats->n_packets' is 0, we can now delete the tests entirely from the
> > cases that previously only ran if 'may_learn'.
> >
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> >
> 
> Acked-by: Joe Stringer <joestringer at nicira.com>

Thanks for the acks on these first three patches.  I added your
additional commentary on patch 2 to the commit message for that patch
and pushed these three to master.



More information about the dev mailing list