[ovs-dev] [PATCH v2] miniflow: Remove unused values_inline branch from miniflow_move()

Ben Pfaff blp at nicira.com
Tue Aug 26 16:08:33 UTC 2014


On Tue, Aug 26, 2014 at 12:01:34PM +0200, Thomas Graf wrote:
> The branch is unused as size < sizeof dst->inline_values must
> always be true for inlined values. Hitting the branch would lead
> to corruption as inline_values is accessed out of bounds.
> 
> Remove branch and add assertion.
> 
> Cc: Jarno Rajahalme <jrajahalme at nicira.com>
> Signed-off-by: Thomas Graf <tgraf at noironetworks.com>

Applied, thanks.



More information about the dev mailing list