[ovs-dev] [PATCH] dpif-netdev: Fix leaked port and port->rxq in error path

Thomas Graf tgraf at noironetworks.com
Tue Aug 26 20:59:25 UTC 2014


On 08/26/14 at 11:28am, Ben Pfaff wrote:
> On Tue, Aug 26, 2014 at 06:36:08PM +0200, Thomas Graf wrote:
> > Signed-off-by: Thomas Graf <tgraf at noironetworks.com>
> > ---
> >  lib/dpif-netdev.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> > index 7401293..c7a1242 100644
> > --- a/lib/dpif-netdev.c
> > +++ b/lib/dpif-netdev.c
> > @@ -669,6 +669,8 @@ do_add_port(struct dp_netdev *dp, const char *devname, const char *type,
> >              VLOG_ERR("%s: cannot receive packets on this network device (%s)",
> >                       devname, ovs_strerror(errno));
> >              netdev_close(netdev);
> > +            free(port->rxq);
> > +            free(port);
> >              return error;
> >          }
> >      }
> 
> This still missed port->type so I redid it as follows and will push in
> a minute after testing.

Thanks!

I copied the code from the error path below which also missed it ;-)



More information about the dev mailing list