[ovs-dev] [PATCH] ovsdb: Catch negative timeout values

Thomas Graf tgraf at noironetworks.com
Tue Aug 26 22:41:50 UTC 2014


Although the check is present already, a missing !error branch
in the next condition prevents the error from being reported back.

Signed-off-by: Thomas Graf <tgraf at noironetworks.com>
---
 ovsdb/execution.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ovsdb/execution.c b/ovsdb/execution.c
index 6314757..2be131d 100644
--- a/ovsdb/execution.c
+++ b/ovsdb/execution.c
@@ -643,6 +643,8 @@ ovsdb_execute_wait(struct ovsdb_execution *x, struct ovsdb_parser *parser,
         } else {
             timeout_msec = LLONG_MAX;
         }
+    }
+    if (!error) {
         if (strcmp(json_string(until), "==")
             && strcmp(json_string(until), "!=")) {
             error = ovsdb_syntax_error(until, NULL,
-- 
1.9.3




More information about the dev mailing list