[ovs-dev] [PATCH] lib/flow.h: Improve struct miniflow comment and definition.

Thomas Graf tgraf at noironetworks.com
Tue Aug 26 22:44:59 UTC 2014

On 08/26/14 at 03:42pm, Jarno Rajahalme wrote:
> Miniflows can nowadays be dynamically allocated to different inline
> sizes, as done by lib/classifier.c, but this had not been documented
> at the struct miniflow definition.
> Also, MINI_N_INLINE had a different value for 32-bit and 64-bit builds
> due to a historical reason.  Now we use 8 for both.
> Finally, use change the storage type of 'values_inline' to uint8_t, as
> uint64_t looks kind of wide for a boolean, even though we intend the
> bit be carved out from the uint64_t where 'map' resides.
> Suggested-by: Ben Pfaff <blp at nicira.com>
> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>

This explains it perfectly, thanks so much!

Reviewed-by: Thomas Graf <tgraf at noironetworks.com>

More information about the dev mailing list