[ovs-dev] [PATCH] lib/flow.h: Improve struct miniflow comment and definition.

Jarno Rajahalme jrajahalme at nicira.com
Tue Aug 26 23:05:31 UTC 2014

On Aug 26, 2014, at 3:44 PM, Thomas Graf <tgraf at noironetworks.com> wrote:

> On 08/26/14 at 03:42pm, Jarno Rajahalme wrote:
>> Miniflows can nowadays be dynamically allocated to different inline
>> sizes, as done by lib/classifier.c, but this had not been documented
>> at the struct miniflow definition.
>> Also, MINI_N_INLINE had a different value for 32-bit and 64-bit builds
>> due to a historical reason.  Now we use 8 for both.
>> Finally, use change the storage type of 'values_inline' to uint8_t, as
>> uint64_t looks kind of wide for a boolean, even though we intend the
>> bit be carved out from the uint64_t where 'map' resides.
>> Suggested-by: Ben Pfaff <blp at nicira.com>
>> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> This explains it perfectly, thanks so much!
> Reviewed-by: Thomas Graf <tgraf at noironetworks.com>

Pushed, thanks! I also reverted the earlier commit. 

I forgot to add your Reviewed-by:, and it seems it is not possible to “git commit —amend” a commit that already is at github — or is it?


More information about the dev mailing list